WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] x86/cpa: make sure cpa is safe to call in lazy m

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] x86/cpa: make sure cpa is safe to call in lazy mmu mode
From: Ingo Molnar <mingo@xxxxxxx>
Date: Wed, 11 Feb 2009 18:44:40 +0100
Cc: kvm-devel <kvm-devel@xxxxxxxxxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Stable Kernel <stable@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>
Delivery-date: Wed, 11 Feb 2009 09:45:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49930BA3.8020305@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <49930BA3.8020305@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> [ Ingo, this needs to go upstream and -stable. -J ]
>
> commit 2193cee29f66b873b9f8ac2cebb2c7b755ec73a3
> Author: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> Date:   Tue Feb 10 14:15:52 2009 -0800
>
>    x86/cpa: make sure cpa is safe to call in lazy mmu mode
>       Impact: fix race leading to crash under KVM and Xen
>
>    The CPA code may be called while we're in lazy mmu update mode - for
>    example, when using DEBUG_PAGE_ALLOC and doing a slab allocation
>    in an interrupt handler which interrupted a lazy mmu update.  In this
>    case, the in-memory pagetable state may be out of date due to pending
>    queued updates.  We need to flush any pending updates before inspecting
>    the page table.  Similarly, we must explicitly flush any modifications
>    CPA may have made (which comes down to flushing queued operations when
>    flushing the TLB).
>       Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>    Acked-by: Marcelo Tosatti <mtosatti@xxxxxxxxxx>

applied to tip:x86/urgent, thanks Jeremy!

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>