| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH] x86: style fascism for xen assemblies
|
To: |
Tejun Heo <htejun@xxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH] x86: style fascism for xen assemblies |
|
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Date: |
Thu, 05 Feb 2009 09:31:22 -0800 |
|
Cc: |
Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, x86@xxxxxxxxxx, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx> |
|
Delivery-date: |
Thu, 05 Feb 2009 09:31:48 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<498B0E13.7060604@xxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<4983AC87.5000304@xxxxxxxx> <498A87B5.3020808@xxxxxxxxx> <20090205150028.GD23903@xxxxxxx> <498B0E13.7060604@xxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Thunderbird 2.0.0.19 (X11/20090105) |
Tejun Heo wrote:
Impact: style cleanup
Make the following sytle cleanups.
* drop unnecessary //#include from xen-asm_32.S
Fine.
* compulsive adding of space after comma
Fine.
* reformat multiline comments
I don't really like what you've done here. There are two problems:
* If you're going to convert comments of the form
/* This is a small comment which
happens to be longer than a line. */
then you should convert it to full winged-style, rather than just
sticking '*' on the front of the second line.
* All the big block comments look crowded and cramped now, which
makes them harder to read and maintain. All those '*'s are just
visual noise. (They make a bit more sense in C code to distinguish
comment from code, but asm code looks so different from comment
that they're not necessary here.)
But Ingo's already pulled it, so I guess I'm stuck with it.
J
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] Booting up the most recent 2.6.29-rc3 (pv_ops Dom0 support) under Xen Unstable on Intel SATA (AHCI) box, (continued)
Message not available
Message not available
- [Xen-devel] Re: [PATCH] x86: style fascism for xen assemblies,
Jeremy Fitzhardinge <=
|
|
|
| |
|
Home