WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/2] ioemu: Enable guest OS to program D0-D3hot s

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/2] ioemu: Enable guest OS to program D0-D3hot states of an assigned device
From: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
Date: Thu, 05 Feb 2009 16:30:46 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Delivery-date: Wed, 04 Feb 2009 23:31:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090204101439.GN25835%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20090203185158.5A4B.SHIMADA-YXB@xxxxxxxxxxxxxxx> <20090204101439.GN25835%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thank you for your review.

On Wed, 4 Feb 2009 19:14:39 +0900
Isaku Yamahata <yamahata@xxxxxxxxxxxxx> wrote:

> On Tue, Feb 03, 2009 at 06:54:45PM +0900, Yuji Shimada wrote:
> > This patch enables guest OS to program D0-D3hot states of assigned
> > device.
> > 
> > Thanks,
> 
> Hi. Just a minor nit.
> 
> LIST_FOREACH() and LIST_FIRST() should be used instead
> of direct use of lh_first, le_next for consistency.

I agree with you that lh_first, le_next should not be used directly.

I will submit a new patch which uses LIST_FOREACH().

> Many "switch(len) case [124] pci_{read, write}_{byte, word, long}():"
> are duplicated. The duplication can be removed by using something like
> the followings (NOTE: I didn't compile it)

I found pci_{read, write}_block in libpci can be used to remove duplication.
I will make the patch use pci_{read, write}_block.

Thanks,
--
Yuji Shimada

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>