WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] xen: fix 32-bit build resulting from mmu move

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] xen: fix 32-bit build resulting from mmu move
From: Ingo Molnar <mingo@xxxxxxx>
Date: Tue, 3 Feb 2009 19:14:25 +0100
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
Delivery-date: Tue, 03 Feb 2009 10:14:58 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <49888787.30803@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <49876C6E.3010809@xxxxxxxx> <20090203122112.GD19979@xxxxxxx> <49887B79.4040708@xxxxxxxx> <20090203173612.GA3528@xxxxxxx> <49888787.30803@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> Ingo Molnar wrote:
>> i have a lot of successful builds with that pattern, that's why i asked 
>> for a specific config from you that definitely triggers it - i'd like 
>> to investigate how it escaped my testing procedures.
>>   
>
> Hm, I don't see how you could be; the functions are just outright  
> missing.  Without the patch, the attached config fails with:
>
> $ make 'ARCH=i386' arch/x86/xen/mmu.o
> [...]
>  CC      arch/x86/xen/mmu.o
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1810: error: 
> 'xen_kmap_atomic_pte' undeclared here (not in a function)
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1816: error: 
> 'xen_set_pte_init' undeclared here (not in a function)
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1824: error: 
> initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1824: error: (near 
> initialization for 'xen_mmu_ops.pte_val')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1825: error: 
> initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1825: error: (near 
> initialization for 'xen_mmu_ops.pgd_val')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1827: error: 
> initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1827: error: (near 
> initialization for 'xen_mmu_ops.make_pte')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1828: error: 
> initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1828: error: (near 
> initialization for 'xen_mmu_ops.make_pgd')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1838: error: 
> initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1838: error: (near 
> initialization for 'xen_mmu_ops.make_pmd')
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1839: error: 
> initializer element is not constant
> /home/jeremy/hg/xen/paravirt/linux/arch/x86/xen/mmu.c:1839: error: (near 
> initialization for 'xen_mmu_ops.pmd_val')
> make[3]: *** [arch/x86/xen/mmu.o] Error 1
> make[2]: *** [arch/x86/xen/mmu.o] Error 2
> make[1]: *** [sub-make] Error 2
> make: *** [all] Error 2
>

hm, it triggers here too. Maybe the count of 32-bit tests wasnt high enough 
yet to hit this.

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel