WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] pv_ops dom0 kernel failure with ata_piix / irq problems

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] pv_ops dom0 kernel failure with ata_piix / irq problems
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Fri, 30 Jan 2009 18:16:20 +0000
Cc: Todd Deshane <deshantm@xxxxxxxxx>, Andrew Lyon <andrew.lyon@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 30 Jan 2009 10:17:17 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1233339176.9970.44.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <495BE5E1.40602@xxxxxxxx> <20090102064444.GN15052@xxxxxxxxxxxxxxx> <20090109174006.GR15052@xxxxxxxxxxxxxxx> <f4527be0901091301p43c8db4bncd02daed4d6755b5@xxxxxxxxxxxxxx> <20090122194645.GJ15052@xxxxxxxxxxxxxxx> <4978D5BE.8090601@xxxxxxxx> <20090124140930.GP15052@xxxxxxxxxxxxxxx> <20090124145844.GQ15052@xxxxxxxxxxxxxxx> <497B64B8.5040709@xxxxxxxx> <20090124201702.GR15052@xxxxxxxxxxxxxxx> <20090124234920.GS15052@xxxxxxxxxxxxxxx> <497BB984.9080803@xxxxxxxx> <1233339176.9970.44.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2009-01-30 at 18:12 +0000, Ian Campbell wrote:
> Possibly the correct fix might be to use xen_register_gsi() here
> instead of xen_allocate_pirq() and get rid of the special case for IRQ
> 14 and 15 in xen_pci_pirq_enable(). Maybe only 14 and 15 need this
> special treatment.

FWIW this also Works For Me.

--- a/arch/x86/xen/pci.c        Fri Jan 30 17:39:54 2009 +0000
+++ b/arch/x86/xen/pci.c        Fri Jan 30 18:16:34 2009 +0000
@@ -75,15 +75,6 @@
 
                printk(KERN_INFO "xen: PCI device %s pin %d -> irq %d\n",
                       pci_name(dev), dev->pin, irq);
-       } else if (((dev->class >> 8) == PCI_CLASS_STORAGE_IDE) &&
-                   (dev->class & 0x05) == 0) {
-               /* Legacy IDE devices have hard-coded irq 14/15 */
-               printk(KERN_INFO "xen: %s: legacy IDE\n", pci_name(dev));
-
-               xen_register_gsi(14, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
-               xen_register_gsi(15, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
-
-               rc = 0;
        } else {
                printk(KERN_INFO "xen: irq enable for %s failed: rc=%d pin=%d 
irq=%d\n",
                        pci_name(dev), rc, dev->pin, dev->irq);
@@ -133,4 +124,6 @@
        /* Blerk. */
        acpi_gbl_FADT.sci_interrupt = irq;
 #endif
+       xen_register_gsi(14, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
+       xen_register_gsi(15, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
 }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>