WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [PATCH 1/4][Xen-devel] X86 microcode: cancel redundant input paramet

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Subject: Re: [PATCH 1/4][Xen-devel] X86 microcode: cancel redundant input parameter of microcode functions
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 22 Jan 2009 11:14:18 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 22 Jan 2009 03:14:43 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200901221207.50153.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acl8gpEsarLR6WMi902O9pu3sDM4mw==
Thread-topic: [PATCH 1/4][Xen-devel] X86 microcode: cancel redundant input parameter of microcode functions
User-agent: Microsoft-Entourage/12.14.0.081024
On 22/01/2009 11:07, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> I think the input parameter 'cpu' is better than 'uci' since 'cpu' is much
>> clear to developer with explicit meaning, so between the 2 redundant
>> parameters 'uci' and 'cpu', we should remove 'uci', just like what native
>> linux microcode functions do.
> 
> What linux does, doesn't matter here. Dom0 just has to make the hypercall.
> This is nothing linux specific.

Like much of Xen's low-level platform code, our microcode mechanism has
direct Linux heritage. Hence keeping as close as possible to those roots
makes upgrades from kernel.org upstream much easier. Hence there is good
reason for caring about closeness to Linux code compared with
solaris/bsd/...

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel