WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Move smp_num_siblings to the per-cpu data

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Move smp_num_siblings to the per-cpu data
From: Frank Van Der Linden <Frank.Vanderlinden@xxxxxxx>
Date: Wed, 21 Jan 2009 09:18:15 -0700
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 21 Jan 2009 08:19:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C59CBC9D.1A8B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C59CBC9D.1A8B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
Keir Fraser wrote:
On 20/01/2009 23:36, "Frank van der Linden" <Frank.Vanderlinden@xxxxxxx>
wrote:

Make the num_siblings CPU parameter per-CPU.

While it is unlikely that a system has a different number of siblings
for different physical CPUs,  make this parameter per-CPU for
consistency, and deal with the (so far theoretical) case that this is
different per CPU package.

Signed-off-by: Frank van der Linden <Frank.Vanderlinden@xxxxxxx>

It's a pretty odd thing to decide to knock together one day. Do you have an
underlying near-term motive for adding this flexibility?

 -- Keir


I originally did this as part of an extension to the MCE support hypercall. We needed some detailed physical CPU information, plus some MSR info. When implementing this, and extracting infro from cpu_data[], I noticed the smp_num_siblings inconsistency, so I changed it.

The other changes will be submitted as a separate patch, after they've been discussed with AMD & Intel.

- Frank


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>