WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] rombios: fix 32bit gateway

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] rombios: fix 32bit gateway
From: Kouya Shimura <kouya@xxxxxxxxxxxxxx>
Date: Thu, 15 Jan 2009 19:13:44 +0900
Delivery-date: Thu, 15 Jan 2009 02:14:39 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
remove unnecessary function calls.

The rombios always becomes read-only after using 32bit gateway.
That is not handy for using the gateway.

Signed-off-by: Kouya Shimura <kouya@xxxxxxxxxxxxxx>

diff -r 10a8fae412c5 tools/firmware/rombios/32bitgateway.c
--- a/tools/firmware/rombios/32bitgateway.c     Wed Jan 14 13:43:17 2009 +0000
+++ b/tools/firmware/rombios/32bitgateway.c     Thu Jan 15 18:34:34 2009 +0900
@@ -126,18 +126,18 @@
 gdt_entry_pm_cs:
     ; 32 bit code segment for protected mode
     .word 0xffff, 0x0000
-    .byte 0x00, 0x9a, 0xcf, 0x00
+    .byte 0x00, 0x9b, 0xcf, 0x00
 
 gdt_entry_pm_16bit_cs:
     ; temp. 16 bit code segment used while in protected mode
     .word 0xffff, 0x0000
-    .byte SEGMENT_OFFSET >> 16, 0x9a, 0x0, 0x0
+    .byte SEGMENT_OFFSET >> 16, 0x9b, 0x0, 0x0
 
 gdt_entry_pm_32bit_ds:
     ; (32 bit) data segment (r/w) reaching all possible areas in 32bit memory
     ; 4kb granularity
     .word 0xffff, 0x0000
-    .byte 0x0, 0x92, 0xcf, 0x0
+    .byte 0x0, 0x93, 0xcf, 0x0
 gdt_entry_end:
 
 my_gdtdesc:
@@ -356,9 +356,6 @@
        call _store_returnaddress       ; store away
        pop ax
 
-       ; XXX GDT munging requires ROM to be writable!
-       call _enable_rom_write_access
-
        rol bx, #2
        mov si, #jmptable
        seg cs
@@ -385,8 +382,6 @@
        mov bp,sp
        push eax                        ; preserve work register
 
-       call _disable_rom_write_access
-
        call _get_returnaddress
        mov 2[bp], ax                   ; 16bit return address onto stack
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] rombios: fix 32bit gateway, Kouya Shimura <=