WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: add SSE-based copy_page()

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, "Dexuan Cui" <dexuan.cui@xxxxxxxxx>, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: add SSE-based copy_page()
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Tue, 13 Jan 2009 08:34:07 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 13 Jan 2009 00:33:54 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C591FDA7.20EC9%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1590c7eb-4c3f-4712-a4ab-c61ce305096e@default> <C591FDA7.20EC9%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 13.01.09 09:13 >>>
>Seems like unless we dynamically choose the copy routine, we're better off
>without the SSE2 alternative. Shall I revert it then?

I'd vote for not reverting it - Xen itself doesn't use copy_page() much, and
whether a domain wants to use MMUEXT_COPY_PAGE could be decided by
it based on its own judgement.

Ultimately we should improve it as you say to dynamically select the copy
method, but then the question really is whether to base the selection on
static CPU information, best cold, or best warm cache performance.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel