xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] fix smbios memory device length boundary condition

from [Bill Rieske]

[Permanent Link][Original]

To:	<xen-devel@xxxxxxxxxxxxxxxxxxx>, <xen-devel-request@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] fix smbios memory device length boundary condition
From:	"Bill Rieske" <brieske@xxxxxxxxxx>
Date:	Fri, 09 Jan 2009 16:58:14 -0700
Delivery-date:	Fri, 09 Jan 2009 15:58:44 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

dev_memsize ends up 0 when it shouldn't be on 16G boundary conditions.

Signed-off-by: Bill Rieske <brieske@xxxxxxxxxx

diff -r 95d77829216f tools/firmware/hvmloader/smbios.c
--- a/tools/firmware/hvmloader/smbios.c Thu Jan 08 11:19:38 2009 +0000
+++ b/tools/firmware/hvmloader/smbios.c Fri Jan 09 16:40:58 2009 -0700
@@ -119,7 +119,7 @@ write_smbios_tables(void *start,
     for ( i = 0; i < nr_mem_devs; i++ )
     {
         uint32_t dev_memsize = ((i == (nr_mem_devs - 1))
-                                ? (memsize & 0x3fff) : 0x4000);
+                                ? (((memsize-1) & 0x3fff)+1) : 0x4000);
         do_struct(smbios_type_17_init(p, dev_memsize, i));
         do_struct(smbios_type_19_init(p, dev_memsize, i));
         do_struct(smbios_type_20_init(p, dev_memsize, i));





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] fix smbios memory device length boundary condition, Bill Rieske <=

Previous by Date:	Re: [Xen-devel] Two shadow page tables for HVM, Emre Can Sezer
Next by Date:	[Xen-devel] PATCH: Allow domains to share instruction pages with each other, Michael Abd-El-Malek
Previous by Thread:	Re: [Xen-devel] Two shadow page tables for HVM, Emre Can Sezer
Next by Thread:	[Xen-devel] PATCH: Allow domains to share instruction pages with each other, Michael Abd-El-Malek
Indexes:	[Date] [Thread] [Top] [All Lists]