WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] hvm_set_callback_irq_level() deadlock?

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] hvm_set_callback_irq_level() deadlock?
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 07 Jan 2009 09:59:07 +0000
Cc:
Delivery-date: Wed, 07 Jan 2009 01:59:46 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <496478DC.9080309@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclwrpQ2M9m3LlgeeUSfLBM93bbKPA==
Thread-topic: [Xen-devel] hvm_set_callback_irq_level() deadlock?
User-agent: Microsoft-Entourage/12.15.0.081119
On 07/01/2009 09:41, "Akio Takebe" <takebe_akio@xxxxxxxxxxxxxx> wrote:

> hvm_set_callback_irq_level() and so on call vioapic_irq_positive_edge()
> before spin_unlock(&d->arch.hvm_domain.irq_lock).
> I think it cause a deadlock.
> If it is right, how should we fix them?
> What do you think?

Doesn't vioapic_irq_positive_edge() clearly expect to be called with that
lock held?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel