WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] Expand shadow memory area for using option ROM

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] Expand shadow memory area for using option ROM
From: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Date: Mon, 05 Jan 2009 18:33:42 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 05 Jan 2009 01:34:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C57E8EC0.1242%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C57E8EC0.1242%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.18 (X11/20081119)
Keir Fraser wrote
On 26/12/2008 04:46, "Akio Takebe" <takebe_akio@xxxxxxxxxxxxxx> wrote:

This patch is:
- replace e820 table from 0xe0000 to 0xeb000.
- expand shadowr from 0xc0000-0xdffff to 0xc0000-0xe8fff.
- fix scan size of VGA BIOS.

after this patch, BIOS map is below.
 BIOS map:
  c0000-c8fff: VGA BIOS
  c9000-d57ff: Etherboot ROM
  d5800-e0fff: PCI Option ROMs
  e9000-e919c: SMBIOS tables
  f0000-fffff: Main BIOS

Comments:

1. Why does the VGA BIOS 'scan size' need to be fixed? What's wrong with
scanning only up to 0xc8000 for it, and letting option ROMs continue to
reside from 0xc8000? Indeed, won't the VGABIOS always be at 0xc0000, so we
could actually only probe that address for it, and let option ROMs load as
low as 0xc0800?

Because the current VGA BIOS uses 0xc0000-0xc8fff from the following log.
I want just to avoid the unnecessary scanning.

(XEN) HVM1: BIOS map:
(XEN) HVM1:  c0000-c8fff: VGA BIOS
(XEN) HVM1:  c9000-d57ff: Etherboot ROM
(XEN) HVM1:  e9000-e919c: SMBIOS tables
(XEN) HVM1:  f0000-fffff: Main BIOS

I think rombios works fine if we drop the part of the patch.


2. It'd be nice to give E820_PHYSICAL_ADDRESS a definition in config.h and
then use that instead of hardcoding the address throughout rombios.c.

I'll try it.

Best Regards,

Akio Takebe

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [Patch] Expand shadow memory area for using option ROM, Akio Takebe <=