WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Patch][RFC] Update rombios.c

To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [Patch][RFC] Update rombios.c
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Thu, 18 Dec 2008 11:18:10 +0000
Cc: Juergen Keil <jk@xxxxxxxx>, Steve Ofsthun <sofsthun@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Stefan Berger <stefanb@xxxxxxxxxx>, Bruce Rogers <brogers@xxxxxxxxxx>, samuel.thibault@xxxxxxxxxx, Ke Liping <liping.ke@xxxxxxxxx>, Ben Guthro <bguthro@xxxxxxxxxxxxxx>, Yu Ke <ke.yu@xxxxxxxxx>, Travis Betak <travis.betak@xxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxx>, Seiji Munetoh <seiji.munetoh@xxxxxxxxx>
Delivery-date: Thu, 18 Dec 2008 03:18:39 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <494911BB.8040506@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <494911BB.8040506@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
Hi,

At 23:50 +0900 on 17 Dec (1229557835), Akio Takebe wrote:
> This patch update rombios to the latest Bochs's.
> I'd like to corabolate bochs community to enhance the guest bios.
> I'm not familiar around TCGBIOS.
> So could you review the patch?
> 
> I tested boot/shutdown, S3 suspend/resume with linux guest.
> Any comments are welcome :-)

Does the boot-options menu work properly after the patch?  This bit of
code looks suspect to me; surely some more translation is necessary to
turn a scan code into an offset into the boot device table:

+      while (!valid_choice) {
+        scan_code = get_keystroke();
+        if (scan_code == 0x01 || scan_code == 0x58) /* ESC or F12 */
+        {
+          valid_choice = 1;
+        }
+        else if (scan_code <= count)
+        {
+          valid_choice = 1;
+          scan_code -= 1;
+          /* Set user selected device */
+          write_word(ebda_seg, IPL_BOOTFIRST_OFFSET, scan_code);
+        }
+      }

Otherwise, this patch looks good to me, though it's enormous so I
haven't looked at every detail.

Also: does this update mean that the Xen rombios now has two separate
32-bit extensions?  Might it be worth using the upstream one instead of
maintaining our own?

Cheers,

Tim.

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel