WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] Dom0-kernel: Fix buggy mask_base insaving/restor

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] Dom0-kernel: Fix buggy mask_base insaving/restoring MSI-X table during S3
From: "Shan, Haitao" <haitao.shan@xxxxxxxxx>
Date: Fri, 28 Nov 2008 20:22:27 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>, 'Keir Fraser' <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 28 Nov 2008 04:22:54 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <492FBED4.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <61563CE63B4F854986A895DA7AD3C1770200EB16@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <61563CE63B4F854986A895DA7AD3C1770200EB2F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <492FB23E.76E4.0078.0@xxxxxxxxxx> <61563CE63B4F854986A895DA7AD3C1770200EC57@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <492FBED4.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclRNjVzVrpnjRqQT3WWXZ+MMKMbUgAHUhvw
Thread-topic: [Xen-devel] [PATCH] Dom0-kernel: Fix buggy mask_base insaving/restoring MSI-X table during S3
Any idea of how to fail suspend/resume?
For example, if we failed in ioremap_nocache, we just do nothing at 
suspend/resume? Let the device to handle it?

Best Regards
Shan Haitao
-----Original Message-----
From: Jan Beulich [mailto:jbeulich@xxxxxxxxxx] 
Sent: 2008年11月28日 16:50
To: Shan, Haitao
Cc: 'Keir Fraser'; 'xen-devel@xxxxxxxxxxxxxxxxxxx'
Subject: RE: [Xen-devel] [PATCH] Dom0-kernel: Fix buggy mask_base 
insaving/restoring MSI-X table during S3

>>> "Shan, Haitao" <haitao.shan@xxxxxxxxx> 28.11.08 09:14 >>>
>Thanks! And updated.
>OK for you?

Only half way: You shouldn't really fail device initialization in that case, all
that should not work is suspend/resume.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel