WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] multi-page blkfront/blkback patch

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Geoffrey Lefebvre <geoffrey@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] multi-page blkfront/blkback patch
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 28 Nov 2008 09:22:57 +0000
Cc: Andrew Warfield <andy@xxxxxxxxx>, Dutch Meyer <dmeyer@xxxxxxxxx>, Samvel Yuri <samvelox@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Delivery-date: Fri, 28 Nov 2008 01:23:10 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <492FBCE4.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclROuZEJPQfFr0uEd2hpQAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] multi-page blkfront/blkback patch
User-agent: Microsoft-Entourage/11.4.0.080122
On 28/11/08 08:41, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> +#ifndef CONFIG_XEN_BLKDEV_NUM_RING_PAGES
>> +#error "CONFIG_XEN_BLKDEV_NUM_RING_PAGES undefined!"
>> +#endif
> 
> This won't work when building unmodified_drivers - I'm not sure what value
> to default to here, though. But for compatibility it should probably be 1,
> and the unmodified drivers' Kbuild could override it if desired.

It should be a module parameter anyway. I don't think there's anything
particularly hard about choosing ring size at run time rather than build
time.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>