xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] x86: secure ioapic_guest_write() against FREE_TO_ASS

from [Jan Beulich]

[Permanent Link][Original]

To:	<xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] x86: secure ioapic_guest_write() against FREE_TO_ASSIGN irq values
From:	"Jan Beulich" <jbeulich@xxxxxxxxxx>
Date:	Wed, 19 Nov 2008 16:05:35 +0000
Delivery-date:	Wed, 19 Nov 2008 08:05:15 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: 2008-10-27/xen/arch/x86/io_apic.c
===================================================================
--- 2008-10-27.orig/xen/arch/x86/io_apic.c      2008-11-19 15:41:31.000000000 
+0100
+++ 2008-10-27/xen/arch/x86/io_apic.c   2008-11-19 16:56:51.000000000 +0100
@@ -2186,7 +2186,7 @@ int ioapic_guest_write(unsigned long phy
     if ( new_rte.vector >= FIRST_DYNAMIC_VECTOR )
         new_irq = vector_irq[new_rte.vector];
 
-    if ( (old_irq != new_irq) && (old_irq != -1) && IO_APIC_IRQ(old_irq) )
+    if ( (old_irq != new_irq) && (old_irq >= 0) && IO_APIC_IRQ(old_irq) )
     {
         if ( irq_desc[IO_APIC_VECTOR(old_irq)].action )
         {
@@ -2198,7 +2198,7 @@ int ioapic_guest_write(unsigned long phy
         remove_pin_at_irq(old_irq, apic, pin);
     }
 
-    if ( (new_irq != -1) && IO_APIC_IRQ(new_irq) )
+    if ( (new_irq >= 0) && IO_APIC_IRQ(new_irq) )
     {
         if ( irq_desc[IO_APIC_VECTOR(new_irq)].action )
         {




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86: secure ioapic_guest_write() against FREE_TO_ASSIGN irq values, Jan Beulich <=

Previous by Date:	Re: [Xen-devel] NR_PIRQS vs. NR_IRQS, Jan Beulich
Next by Date:	Re: [Xen-devel] NR_PIRQS vs. NR_IRQS, Keir Fraser
Previous by Thread:	[Xen-devel] megaraid sas driver failing in Xen-3.4 unstable version, Manyam, Ramesh
Next by Thread:	[Xen-devel] RE: [Xen-users] GPLPV 0.9.12-pre4 uploaded, Nick Couchman
Indexes:	[Date] [Thread] [Top] [All Lists]