WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] linux/x86: remove broken HYPERVISOR_acm_op()

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] linux/x86: remove broken HYPERVISOR_acm_op()
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 19 Nov 2008 09:06:50 +0000
Delivery-date: Wed, 19 Nov 2008 01:06:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
That hypercall apparently never really worked (it's being passed two
arguments, but the hypercall entry point code only loaded one, while
do_acm_op() again consumed two), appears to be pointless in the kernel
anyway, and there's been no __HYPERVISOR_acm_op for quite a while.

As usual, written and tested on 2.6.27.6 and made apply to the 2.6.18
tree without further testing.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- a/include/asm-i386/mach-xen/asm/hypercall.h
+++ b/include/asm-i386/mach-xen/asm/hypercall.h
@@ -279,13 +279,6 @@
        return rc;
 }
 
-static inline int __must_check
-HYPERVISOR_acm_op(
-       int cmd, void *arg)
-{
-       return _hypercall2(int, acm_op, cmd, arg);
-}
-
 static inline int __must_check
 HYPERVISOR_xen_version(
        int cmd, void *arg)
--- a/include/asm-x86_64/mach-xen/asm/hypercall.h
+++ b/include/asm-x86_64/mach-xen/asm/hypercall.h
@@ -277,13 +277,6 @@
        return rc;
 }
 
-static inline int __must_check
-HYPERVISOR_acm_op(
-       int cmd, void *arg)
-{
-       return _hypercall2(int, acm_op, cmd, arg);
-}
-
 static inline int __must_check
 HYPERVISOR_xen_version(
        int cmd, void *arg)




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] linux/x86: remove broken HYPERVISOR_acm_op(), Jan Beulich <=