WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [patch] netfront: unregister net device at backend_chang

To: Joe Jin <joe.jin@xxxxxxxxxx>
Subject: [Xen-devel] Re: [patch] netfront: unregister net device at backend_changed() if network_connect() failed
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 18 Nov 2008 12:49:56 +0000
Cc: Xen-Devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 18 Nov 2008 04:50:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <fb621f45-1699-4159-b5f9-3b91edad4929@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclJfChwZyUaeLVvEd2X7QAX8io7RQ==
Thread-topic: [patch] netfront: unregister net device at backend_changed() if network_connect() failed
User-agent: Microsoft-Entourage/11.4.0.080122
On 18/11/08 12:21, "Joe Jin" <joe.jin@xxxxxxxxxx> wrote:

>> If virtual devices are failing to initialise then a confusing no-mac
>> interface is presumably the least of the user's worries?
> 
> However, initialized failed means device was unavailable, but
> at system ifconfig -a also show it, might be user ask what is
> it? why it disabled? is there anything wrong on my systgem :-)

And they'd be right wouldn't they: Yes, something *is* wrong! :-)

> So, I think if device failed to initialise we'd better unregister
> it. how do you think?

Have you actually seen this problem occur, in stress tests or elsewhere? Or
is this just a 'nice to have'? If the former I'd rather fix the bug!

One concern I have is that leaving an interface structure allocated but
unregistered is not a state we've previously handled in netfront, and could
cause bad kernel behaviour if, for example, the netif gets unprobed later.

 -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel