WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] enable hpet after s3 resume

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] enable hpet after s3 resume
From: "Guanqun Lu" <guanqun.lu@xxxxxxxxx>
Date: Tue, 18 Nov 2008 20:11:53 +0800
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Lu, Guanqun" <guanqun.lu@xxxxxxxxx>, xen-devel组 <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 18 Nov 2008 04:12:21 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=Tlf3DQ68O7b8wkl91fVInDkgOGAa7+Y1pRwJ9mQjOek=; b=xT6+aRoCzVaBYyBvxZ3aSUjGbW388nOQUvHks6skYlfacuGHlDdvVS3UJ+4/6Y15JH 5pyWFWrwWx3friLxMlY2ZCjchNqYgmsr/NwG6ujn/o/uafHBvMOrooci6asDYrmd/+QL rucKitTfoBiDqs35k39b/Ndt8Ib6I+xJE4AWg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=CQO4afvD+RgY/coU4im26G3Pd6vTFNSo7tqNk9mqo8CrETtuTT4HqxZgmsGpsIX2Hv qdL+rdFJTzP4BlbvgfgPkCWmb3bEHRiX4GBsDLkkbLjPqRppbStEM0LzInUMUPqQM9xl hhTFm3GCZFMiLNTMcwmzP9eyuxtVV3H9kTneE=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C548464A.1F528%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <0A882F4D99BBF6449D58E61AAFD7EDD601E23B27@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C548464A.1F528%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, Nov 18, 2008 at 6:15 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> On 18/11/08 10:04, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:
>
>>> The hpet.c changes are ugly. What's so special about
>>> hpet_broadcast_init()
>>> that it needs to distinguish between boot and S3 resume? In
>>> the latter case
>>> it executes with APs still offline and IRQs disabled, so
>>> what's wrong with
>>> rewriting the fixmap entry, re-initialising the spinlock and hpet_event
>>> info?
>>
>> Is it safe to set fixmap entry twice without unmap? If yes, then
>> agree same logic applies to both boot and S3 resume.
>
> Yes, all it does is write a pte.

Thanks for you info, and we will rewrite the patch accordingly.

>
>  -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>



-- 
Guanqun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>