WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] grant table interface addition?

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] grant table interface addition?
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 31 Oct 2008 17:00:04 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 31 Oct 2008 10:00:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <490B3F18.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ack7eh54XOqBKqdtEd2uKgAWy6hiGQ==
Thread-topic: [Xen-devel] grant table interface addition?
User-agent: Microsoft-Entourage/11.4.0.080122
On 31/10/08 16:23, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 31.10.08 17:17 >>>
>> On 31/10/08 16:13, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>> 
>>>> GRANT_PTE_FLAGS should include _PAGE_GUEST_KERNEL then?
>>> 
>>> No, it should uniformly include neither _PAGE_USER nor _PAGE_GUEST_KERNEL.
>>> _PAGE_USER gets set when GNTMAP_application_map is specified, and
>>> based on this setting of _PAGE_USER, adjust_guest_l1e() will set either
>>> _PAGE_GUEST_KERNEL or _PAGE_GLOBAL.
>> 
>> The grant code doesn't use adjust_l1e() though.
> 
> Both create_grant_pte_mapping() and create_grant_va_mapping() do
> afaics.

Ah yes, indeed. Please send a patch to deal with this and _PAGE_NX.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel