WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] x86: fix preemptable page typehandling(v2)

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86: fix preemptable page typehandling(v2)
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 30 Oct 2008 17:27:05 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 30 Oct 2008 10:27:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4909F703.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ack6tLo/+Ov74aanEd2zLQAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] x86: fix preemptable page typehandling(v2)
User-agent: Microsoft-Entourage/11.4.0.080122
On 30/10/08 17:03, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> This would be basically a small cmpxchg() loop. Since it's only executed
>> before setting PGT_partial we know that only one such special reference is
>> needed per page and we could just make get_page() leave headroom of one
>> reference.
>> 
>> Simpler code and faster code?
> 
> Yes - admittedly I had expected you to dislike a special casing approach like
> this...

I think it will overall make the code clearer.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel