WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][Retry 1] NextRIPS support for forthcoming AMD pr

To: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Mark Langsdorf <mark.langsdorf@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH][Retry 1] NextRIPS support for forthcoming AMD processors
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 17 Oct 2008 12:14:13 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 17 Oct 2008 04:14:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <de76405a0810170248q29ec1ba9qc46aff357fe402f6@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AckwSXwguql+Lpw8Ed2ajQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH][Retry 1] NextRIPS support for forthcoming AMD processors
User-agent: Microsoft-Entourage/11.4.0.080122


On 17/10/08 10:48, "George Dunlap" <George.Dunlap@xxxxxxxxxxxxx> wrote:

> Hmm... won't this giant case statement expand out into a huge string
> of ifs?  It seems like we should be able to be more clever than that
> for the common case.

It's actually only a sanity check since nrip will be valid for all current
callers. I've now made the switch statement compiled in only for debug
builds, and BUG() if it fails. Changeset 18644.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>