WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: [PATCH] Share the IO_APIC_route_entry with iosapic

To: 'Keir Fraser' <keir.fraser@xxxxxxxxxxxxx>, "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Xu, Anthony" <anthony.xu@xxxxxxxxx>
Subject: [Xen-devel] RE: [PATCH] Share the IO_APIC_route_entry with iosapic
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Tue, 7 Oct 2008 15:24:40 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc:
Delivery-date: Tue, 07 Oct 2008 00:25:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C5050E94.1DAB4%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F4AE3CDE26E0164D9E990A34F2D4E0DF088794B753@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C5050E94.1DAB4%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AckgiO9bcpoCwP60QhSSqGPREIpSFQAkJdlgAAYECKAABwJS6wG/ibPA
Thread-topic: [PATCH] Share the IO_APIC_route_entry with iosapic
Hi Keir,
The iosapic continues to stay inside arch/ia64/; on the other hand, I think the 
struct 'IO_APIC_route_entry' should be placed to a common place so that IPF and 
x86 can share most of the common codes, like interrupt remapping.
To make the most use most use of the current x86 VT-d code, I personally think 
this movement of thedefinition of the struct IO_APIC_route_entry is necessary 
here.
Could you please comment this more?

Thanks,
-- Dexuan


-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
Sent: 2008年9月28日 17:36
To: Cui, Dexuan; 'xen-devel@xxxxxxxxxxxxxxxxxxx'
Subject: Re: [PATCH] Share the IO_APIC_route_entry with iosapic

If the code using this definition will be shared too, that's one thing. If
you're actually going to put all the code under arch/ia64 (which you seem to
imply), then duplicating this structure in include/asm-ia64 is okay. It's
not like it's changing, ever. I personally think that striving to share
architectural definitions in all cases, even where that may twist the header
#includes, is not necessarily a good idea. So it depends what your end goal
is.

 -- Keir

On 28/9/08 07:52, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> The patch moves the struct IO_APIC_route_entry to a common place.
> This allows us to share the struct with iosapic.
>
> Thanks,
> -- Dexuan
>
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel