| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-ia64-devel] Re: [PATCH] xm: Don't spawn vncviewer twice.
Isaku Yamahata writes ("[PATCH] xm: Don't spawn vncviewer twice."):
> Hi. I found this issue with IA64 box while looking at the c/s of
> 18204:21dd1fdb73d8, but I believe the things is same with x86 box.
Summary: I agree with the change but the commit message should read:
Remove obsolete mechanism using vncviewer -listen
(Your numbers are out of sequence: over here 21dd1fdb73d8 is 18178.)
Since 21dd1fdb73d8 there have been (as far as I can see) three
separate mechanisms for achieving a VNC display:
1. xm spawns vncviewer after getting vnc display info
from qemu-dm via xenstore (introduced in 21dd1fdb73d8)
2. xm spawns vncviewer -listen and qemu-dm connects to it
3. qemu-dm spawns vncviewer (!)
The latter two are are rather strange - No.3 is very strange indeed.
So I decided that rather than try to get No.2 or No.3 on track for
going into qemu upstream, I would drop them. After discussion on
xen-devel I introduced the mechanism No.1, above.
No.1 is controlled by the --spawn-vncviewer (and --vncviewer-autopass)
command line options to xm, by analogy with the -c option.
Nos.2 and 3 are controlled by elements of the domain configuration
file - and their code still remains. So if you turn all of the vnc
options on you can get several vncviewers (although only one of them
will work).
I think it is good to remove the support for the passive connection
mode No.2, which is what your patch seems to do. After all
ioemu-remote will never connect to such a vncviewer. The options to
engage this functionality were already removed from the example config
files by Keir in 18241:bf4ef45e6a38.
> I'm not sure whether this patch coexist with the old ioemu which
> is to be removed soon. So it might be desirable to apply
> this patch after deleting the internal ioemu tree.
I think the old tree is pretty much dead now ...
Ian.
_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
|
|
|
| |
|
Home