[Xen-devel] [PATCH] avoid parallel invocation of git for ioemu-remote

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

The stubdom and tools directories both run `make ioemu-dir-find' in
tools.  In a parallel build, both these invocations can run
concurrently because we're doing recursive make.

This change fixes this problem by adding a suitable dependencies in
the top-level Makefile for the recursion into tools/ and stubdom/,
ensuring that the git fetch happens once, first.

The bug was introduced in 18472/18474.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r 75c4a603d9cd Makefile
--- a/Makefile  Mon Sep 15 15:44:38 2008 +0100
+++ b/Makefile  Mon Sep 15 12:20:58 2008 +0100
@@ -64,7 +64,7 @@ install-xen:
        $(MAKE) -C xen install
 
 .PHONY: install-tools
-install-tools:
+install-tools: tools/ioemu-dir
        $(MAKE) -C tools install
 
 .PHONY: install-kernels
@@ -72,11 +72,14 @@ install-kernels:
        for i in $(XKERNELS) ; do $(MAKE) $$i-install || exit 1; done
 
 .PHONY: install-stubdom
-install-stubdom:
+install-stubdom: tools/ioemu-dir
        $(MAKE) -C stubdom install
 ifeq (x86_64,$(XEN_TARGET_ARCH))
        XEN_TARGET_ARCH=x86_32 $(MAKE) -C stubdom install-grub
 endif
+
+tools/ioemu-dir:
+       make -C tools ioemu-dir-find
 
 .PHONY: install-docs
 install-docs:

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel