Re: [Xen-devel] [PATCH] xen/Makefile: use CC --version instead of -v

[Robert Buchholz <rbu@xxxxxxxxxx>]

On Wednesday 27 August 2008, Keir Fraser wrote:
> On 27/8/08 00:06, "Robert Buchholz" <rbu@xxxxxxxxxx> wrote:
> > I propose to change the statement to:
> >   $(CC) $(CFLAGS) --version | head -n1
>
> I think we can just tighten up the grep regexp a little.
>
> "gcc .*version " should do it.

That is not guaranteed to filter only the desired lines (if a configure 
parameter would end in "gcc", or there is "gcc " in the path GCC was 
compiled in).
The reason I proposed "gcc --version | head -n1" was that the output is 
only dependent on the GCC source, whereas "gcc -v | grep"  also depends 
on the system configuration.

Btw, what is the reason for ".*" in the first place?


Regards,
Robert

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel