Re: [Xen-devel] [PATCH] mini-os: make xenbus_read_integer and xe

Daniel P. Berrange, le Tue 26 Aug 2008 17:34:37 +0100, a écrit :
> If you annotate that declaration with
> 
>    __attribute__ ((__format__ (printf, 4, 3)))
> 
> then gcc will warn you any time a caller gives incorrect args vs
> format string, which can catch some otherwise hidden bugs.

Indeed, actually all mini-os's *print* functions should have it, IIRC
there are a lot of fixes needed to have this compile with -Werror :)

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] mini-os: make xenbus_read_integer and xenbus_printf take const strings, Samuel Thibault Re: [Xen-devel] [PATCH] mini-os: make xenbus_read_integer and xenbus_printf take const strings, Daniel P. Berrange Re: [Xen-devel] [PATCH] mini-os: make xenbus_read_integer and xenbus_printf take const strings, Samuel Thibault <=

Previous by Date:

Re: [Xen-devel] Re: [Qemu-devel] [PATCH 01/13] Handle terminating signals., Anthony Liguori

Next by Date:

[Xen-devel] [PATCH] mini-os: Add printf format checking to xenbus_printf, Samuel Thibault

Previous by Thread:

Re: [Xen-devel] [PATCH] mini-os: make xenbus_read_integer and xenbus_printf take const strings, Daniel P. Berrange

Next by Thread:

[Xen-devel] [PATCH] PyGRUB: fix menu flicker, Samuel Thibault

Indexes:

[Date] [Thread] [Top] [All Lists]

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] mini-os: make xenbus_read_integer and xenbus_pri