[Xen-devel] [PATCH][LINUX] don't WARN_ON -ENOSYS from PHYSDEVOP_manage_pci_remove

[Alex Williamson <alex.williamson@xxxxxx>]

We let -ENOSYS slip through on the add side to support old hypervisors,
let's do the same on the remove end so we don't get stack dumps during
bootup.

Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
--

diff -r 2866e6af503e drivers/xen/core/pci.c
--- a/drivers/xen/core/pci.c    Thu Jul 31 15:33:54 2008 +0100
+++ b/drivers/xen/core/pci.c    Thu Aug 07 15:14:07 2008 -0600
@@ -23,9 +23,13 @@ static int pci_bus_probe_wrapper(struct 
                return r;
 
        r = pci_bus_probe(dev);
-       if (r)
-               WARN_ON(HYPERVISOR_physdev_op(PHYSDEVOP_manage_pci_remove,
-                                             &manage_pci));
+       if (r) {
+               int ret;
+
+               ret = HYPERVISOR_physdev_op(PHYSDEVOP_manage_pci_remove,
+                                           &manage_pci);
+               WARN_ON(ret && ret != -ENOSYS);
+       }
 
        return r;
 }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel