WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver

To: Blue Swirl <blauwirbel@xxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver.
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Mon, 04 Aug 2008 20:15:06 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, qemu-devel@xxxxxxxxxx
Delivery-date: Mon, 04 Aug 2008 11:15:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f43fc5580808040952o7dc14337i864978b0df2623f3@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1217865045-10722-1-git-send-email-kraxel@xxxxxxxxxx> <1217865045-10722-4-git-send-email-kraxel@xxxxxxxxxx> <f43fc5580808040952o7dc14337i864978b0df2623f3@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080501)
Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>>  +       buffer->data = realloc(buffer->data, buffer->capacity);
> 
> On Qemu, instead of malloc,  qemu_malloc should be used to allocate
> memory. Though there isn't qemu_realloc.

Should I add qemu_realloc then?

>>  +    if (!type || 0 != strcmp(type, "ioemu")) {
> 
> Shouldn't this be "qemu"?

No, "ioemu" is correct.  xend writes that value into xenstore.

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>