Re: [PATCH] Re: [Xen-devel] distclean failure

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>]

Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:40:31 -0700, a écrit :
> Samuel Thibault wrote:
> >Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit :
> >  
> >>>+  [ ! -d libxc ] || $(MAKE) -C libxc clean
> >>>+  [ ! -d ioemu ] || $(MAKE) -C ioemu clean
> >>>      
> >>Are you sure you don't not need a double negative there?
> >>    
> >
> >Mmm, why?  The clean target succeeds if either there is not even
> >libxc/ioemu directories, or the make clean there works.
> >  
> 
> I'm just pointing out that
> 
>       [ -d libxc ] && $(MAKE) -C libxc clean
> 
> is more straightforward.

But it makes the rule fail if the directory doesn't exist.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel