WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [PATCH] Re: [Xen-devel] distclean failure

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [PATCH] Re: [Xen-devel] distclean failure
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Fri, 1 Aug 2008 21:42:45 +0100
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 01 Aug 2008 13:43:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <489374BF.4010802@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <200808011614.56245.Christoph.Egger@xxxxxxx> <20080801141820.GU4553@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <489371B1.1030600@xxxxxxxx> <20080801203642.GB4526@implementation> <489374BF.4010802@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:40:31 -0700, a écrit :
> Samuel Thibault wrote:
> >Jeremy Fitzhardinge, le Fri 01 Aug 2008 13:27:29 -0700, a écrit :
> >  
> >>>+  [ ! -d libxc ] || $(MAKE) -C libxc clean
> >>>+  [ ! -d ioemu ] || $(MAKE) -C ioemu clean
> >>>      
> >>Are you sure you don't not need a double negative there?
> >>    
> >
> >Mmm, why?  The clean target succeeds if either there is not even
> >libxc/ioemu directories, or the make clean there works.
> >  
> 
> I'm just pointing out that
> 
>       [ -d libxc ] && $(MAKE) -C libxc clean
> 
> is more straightforward.

But it makes the rule fail if the directory doesn't exist.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel