WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-ia64-devel] [PATCH 2 of 2] cross-build fixes in ioemu-remote

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [PATCH 2 of 2] cross-build fixes in ioemu-remote
From: Aron Griffis <aron@xxxxxx>
Date: Thu, 31 Jul 2008 10:51:40 -0400
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 31 Jul 2008 08:09:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1217515898@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
Partly fix cross-building in ioemu-remote:

- Don't call install -s; it uses the host strip program which
  doesn't understand cross-built binaries.  This same change was
  in the legacy ioemu dir.

- The ioemu version of cc-option doesn't take $(CC) as the first
  argument, so all builds were getting -msse2 regardless of
  architecture.

Signed-off-by: Aron Griffis <aron@xxxxxx>

diff --git a/Makefile b/Makefile
index bebd244..b055b3f 100644
--- a/Makefile
+++ b/Makefile
@@ -205,7 +205,7 @@ endif
 install: all $(if $(BUILD_DOCS),install-doc)
        mkdir -p "$(DESTDIR)$(bindir)"
 ifneq ($(TOOLS),)
-       $(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
+       $(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
 endif
        mkdir -p "$(DESTDIR)$(datadir)"
        set -e; for x in bios.bin vgabios.bin vgabios-cirrus.bin ppc_rom.bin \
diff --git a/Makefile.target b/Makefile.target
index 1aace9c..e796d61 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -707,7 +707,7 @@ clean:
 
 install: all install-hook
 ifneq ($(PROGS),)
-       $(INSTALL) -m 755 -s $(PROGS) "$(DESTDIR)$(bindir)"
+       $(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
 endif
 
 # Include automatically generated dependency files
diff --git a/xen-hooks.mak b/xen-hooks.mak
index af977ef..c90f546 100644
--- a/xen-hooks.mak
+++ b/xen-hooks.mak
@@ -3,7 +3,7 @@ CPPFLAGS+= -I$(XEN_ROOT)/tools/xenstore
 CPPFLAGS+= -I$(XEN_ROOT)/tools/include
 CPPFLAGS+= -I$(XEN_ROOT)/tools/blktap/lib
 
-SSE2 := $(call cc-option,$(CC),-msse2,)
+SSE2 := $(call cc-option,-msse2,)
 ifeq ($(SSE2),-msse2)
 CFLAGS += -DUSE_SSE2=1 -msse2
 endif


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel