|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH] gnttab_setup_table error case
To: |
Qing He <qing.he@xxxxxxxxx> |
Subject: |
Re: [Xen-devel] [PATCH] gnttab_setup_table error case |
From: |
Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx> |
Date: |
Thu, 31 Jul 2008 09:58:58 +0100 |
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Diego Ongaro <diego.ongaro@xxxxxxxxxx> |
Delivery-date: |
Thu, 31 Jul 2008 01:59:39 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<20080731020828.GA5842@ub-qhe2> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Mail-followup-to: |
Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, Qing He <qing.he@xxxxxxxxx>, Diego Ongaro <diego.ongaro@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx |
References: |
<489069F3.7070200@xxxxxxxxxx> <20080731020828.GA5842@ub-qhe2> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
User-agent: |
Mutt/1.5.12-2006-07-14 |
Qing He, le Thu 31 Jul 2008 10:08:28 +0800, a écrit :
> On Wed, 2008-07-30 at 14:17 +0100, Diego Ongaro wrote:
> > gnttab_setup_table should set an error status code if the gmfn it gets
> > for a grant table page is invalid.
> >
> > I ran into this issue when I tried to set up the grant table during hvm
> > domain creation, and it caused a BUG_ON later down the line. With this
> > patch, the hypercall will gracefully fail instead.
>
> Do you use 32bit guest on top of 64bit hypervisor?
No, just 64/64.
> Just curious, but why we want to call setup_table in HVM in the first
> place. Since HVM has its isolated address space, it will always fail.
That was for his personal project. The call was made from dom0. The
problem is that it triggers a BUG_ON, which we do not really want to
happen :)
> 1. let setup_table return -ENOSYS again in HVM?
That could make sense.
Samuel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|