WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] RFC: Making QEMU honour 'readonly' flag for disks

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] RFC: Making QEMU honour 'readonly' flag for disks
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Thu, 24 Jul 2008 14:41:47 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 24 Jul 2008 06:42:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18568.34189.57005.491667@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20080724113627.GU1138@xxxxxxxxxx> <18568.34189.57005.491667@xxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Thu, Jul 24, 2008 at 02:37:17PM +0100, Ian Jackson wrote:
> Daniel P. Berrange writes ("[Xen-devel] RFC: Making QEMU honour 'readonly' 
> flag for disks"):
> > This proof of concept patch I've done against the RHEL-5 Xen tree introduces
> > a new 'drv_read_only' flag to QEMU's BlockDriverState struct, and if set to
> > non-zero, will cause the individual block backend drivers inside QEMU to 
> > always open with O_RDONLY, and never try O_RDWR. Ultimately this would be
> > hooked up to the '-drive' parameter via a extra flag ',ro' in its args.
> > It then makes xenstore.c set this flag based on the 'mode' parameter for
> > the disk in xenstore.
> 
> I think this is a good idea but you should discuss it with upstream to
> try to minimise the difference between the patch that goes into our
> tree and the one that goes into upstream.

Ok, I'll do a generic patch for upstream QEMU and then a xenstore integration
add on.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel