WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] domain destory path is not correct on c/s 18117

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] domain destory path is not correct on c/s 18117
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 24 Jul 2008 13:06:23 +0100
Cc: "Han, Weidong" <weidong.han@xxxxxxxxx>
Delivery-date: Thu, 24 Jul 2008 05:06:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200807241323.51454.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjthbCj7zz1KFl4Ed224QAX8io7RQ==
Thread-topic: [Xen-devel] domain destory path is not correct on c/s 18117
User-agent: Microsoft-Entourage/11.4.0.080122


On 24/7/08 12:23, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> Or you removed the munmap() from the tail of loadelfimage(). Putting it
>> back fixes the bug. Changeset 18118.
> 
> Ah, right. I didn't notice that munmap() was called in both failure and
> _succuss_ case of xc_map_foreign_ranges().
> Thanks for fixing this.

'out' would have been a more appropriate label than 'err'. :-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel