[Xen-devel] [PATCH] [HVM] Fix intra-vga-mem mmio in stdvga.c

To:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] [HVM] Fix intra-vga-mem mmio in stdvga.c
From:	"Trolle Selander" <trolle.selander@xxxxxxxxx>
Date:	Wed, 23 Jul 2008 13:05:58 +0100
Cc:
Delivery-date:	Wed, 23 Jul 2008 05:06:24 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type; bh=wF4z6pUd229HgADNnVAwKVBeMFchx0ntZCMm+agHGuY=; b=iNsU6JRrewDgecRMcGSaEmt8bbRQdWzdIV30PeJqg1ujWjfYxOjVW+gd0tXOuMKqX4 BNd4Us0gsjDiMRij0OD2UcHHVLrCys7+pqlAvN/8FXz65rDirp27GQfu3SM5fkk70USQ CxWT9GivxpsUJceSlBhN+eIqE/P9PsLWuQ31c=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=cIDj3Y8Rn6YXdeBxvjKiOV/Nqp2n+7mGBQXLjmYgvrSOd8/Xk4P55ruiCmrCtvMQrR gZaBHRTyyUZByW+vNC/Mz3Acl8mooRw8MdtkoIoz3CQJVAy4tflQKO9ypeZyRK+4fN7s JLn5tkbhOF64PsHLQQzycW3WEuTpXviD7BoKM=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

The current stdvga code never checks if the copy_from/to_guest calls fail, and thus silenty fails if both sides of an IOREQ_COPY points into mmio space. This patch fixes this and makes the code correctly handle intra-vga-mem copies, as well as log & turn off caching if some more "exotic" type of mmio (say, copy from vga mem to some other device's iomem), so that such mmio reqs will fall through to regular ioemu where they can hopefully be handled correctly.

In practice, this patch fixes a number of graphical glitches for guests running in standard vga mode, including a corrupted OS/2 boot graphic.

Signed-off-by: Trolle Selander <trolle.selander@xxxxxxxxxxxxx>

xen_hvm_stdvga_fix.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] [PATCH] [HVM] Fix intra-vga-mem mmio in stdvga.c