[Xen-devel] [PATCH] ioemu hvmloader erronoeous debugging prints

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

This patch fixes the types of some values passed to printf in
tools/ioemu/hw/pc.c.  Without it, on i386 at least, the values printed
are wrong because the printf argument type and argument sizes do not
match.

I'm submitting this change for ioemu just in case I have to debug
ioemu-remote (the merged qemu tree) in this area again :-).

hw/pc.c generates several warnings of this kind of problem, but these
appear to be the ones which actually cause wrong output.

Ian.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r 39c2cab9e765 tools/ioemu/hw/pc.c
--- a/tools/ioemu/hw/pc.c       Mon Jul 14 10:12:07 2008 +0100
+++ b/tools/ioemu/hw/pc.c       Tue Jul 22 15:56:31 2008 +0100
@@ -591,9 +591,9 @@ static void load_linux(const char *kerne
             "qemu: real_addr     = %#zx\n"
             "qemu: cmdline_addr  = %#zx\n"
             "qemu: prot_addr     = %#zx\n",
-            real_addr,
-            cmdline_addr,
-            prot_addr);
+            (size_t)real_addr,
+            (size_t)cmdline_addr,
+            (size_t)prot_addr);
 
     /* highest address for loading the initrd */
     if (protocol >= 0x203)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel