WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][TOOLS] libfsimage, pygrub, python: cleanup

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][TOOLS] libfsimage, pygrub, python: cleanup
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Fri, 18 Jul 2008 16:15:07 +0100
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 18 Jul 2008 08:15:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <18560.42053.605918.889433@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200807151543.16172.Christoph.Egger@xxxxxxx> <20080715223624.GA1589@xxxxxxxxxxxxxxxxxxxxxxx> <18560.42053.605918.889433@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Jul 18, 2008 at 03:10:13PM +0100, Ian Jackson wrote:

> > >  fsi_plugin_ops_t *
> > > +fsi_init_plugin(int version, fsi_plugin_t *fp, const char **name);
> > > +
> > > +fsi_plugin_ops_t *
> > >  fsi_init_plugin(int version, fsi_plugin_t *fp, const char **name)
> 
> The purpose of -Wmissing-prototypes is to spot this situation:

Indeed.

> However if you don't understand this, you may do what the submitter of
> this patch did, which is to change a.c to read like this:
> 
>   a.c:  int function(void);
>         int function(void) { return 1; }
> 
> This completely defeats the point of -Wmissing-prototypes; I think
> it's just wrong.

It doesn't even make sense for the compiler to warn about the above
though. It's not called anywhere (that the compiler can detect:
certainly not in that C file).

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel