WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Patch attachment format (was Re: [Xen-devel] [PATCH] Fix issues when pas

To: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
Subject: Patch attachment format (was Re: [Xen-devel] [PATCH] Fix issues when passthrough device is hot-removed from HVM domain.)
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 18 Jul 2008 15:15:20 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 18 Jul 2008 07:16:02 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20080716091806.B4D6.SHIMADA-YXB@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <20080716091806.B4D6.SHIMADA-YXB@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Yuji Shimada writes ("[Xen-devel] [PATCH] Fix issues when passthrough device is 
hot-removed from HVM domain."):
> When passthrough device is hot removed from HVM domain by "xm
> pci-detach" command, following issues occur. The patch fixes them.
>    - Allocated memory is not deallocated.
>    - Unbind interrupt with invalid interrupt pin.
>    - MSI-X memory mapped register area is not unmapped.

Thanks for this patch.

However can you please ask your program to stop marking these patches
as if they were opaque binary data attachments ?  That makes it hard
for other people using normal mailreaders to review your changes -
sometimes we even have to save the patch to a file, because your
mailer has tagged it as if it were a binary file like a kernel image
or something.

I don't know how to achieve this with your mailer, but it's possible
that changing the patch filename from `*.patch' to `*.txt' will help.

(At a technical level, what I'm complaining about is this MIME data
for the body part containing the patch:
    Content-Type: application/octet-stream;
     name="fix_hot-remove.patch"
    Content-Disposition: attachment;
     filename="fix_hot-remove.patch"
`application/octet-stream' is wrong and should read `text/plain', or
perhaps `text/x-patch' or something.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>