WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH 2/2] open ptys in non-blocking mode.

To: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 2/2] open ptys in non-blocking mode.
From: Kevin Wolf <kwolf@xxxxxxx>
Date: Fri, 18 Jul 2008 11:14:11 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx
Delivery-date: Fri, 18 Jul 2008 02:16:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <48805DE9.9050105@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1215605958-22623-1-git-send-email-kraxel@xxxxxxxxxx> <1215605958-22623-2-git-send-email-kraxel@xxxxxxxxxx> <4880574C.1020703@xxxxxxx> <48805DE9.9050105@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.12 (X11/20071114)
Gerd Hoffmann schrieb:
> Kevin Wolf wrote:
>> [Crossposting to xen-devel]
>>
>> Ian, we need something like this for qemu-xen (or ioemu-remote or
>> whatever it's called now). Currently you must attach to the console of a
>> domain, otherwise it won't boot up and keep hanging in a blocking write
>> because the buffer is full.
>>
>> The old ioemu had a hack in unix_write (doing a select before the write)
>> which you didn't merge into qemu-xen. In fact, I noticed that you even
>> removed that function entirely and I'm wondering why.
> 
> For completeness:  You also need the attached patch for unix_write,
> otherwise you'll end up with qemu burning cpu cycles.  If you can't
> write to a non-blocking file handle the write will instantly return with
> -EAGAIN.  Calling it again of course doesn't change the result, so
> better don't do that ...

As I metioned above, in qemu-xen there is no unix_write. It calls
write() directly instead. But if we wanted to re-introduce unix_write to
be closer to upstream qemu (I still don't know why unix_write was
dropped in the first place for qemu-xen - Ian?) you're right, of course.

Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel