WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ioemu-remote: Fix pci pass-through

To: Jean Guyader <jean.guyader@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ioemu-remote: Fix pci pass-through
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2008 17:36:28 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 15 Jul 2008 09:36:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <487CCF5D.9090200@xxxxxxxxxxxxx> <487CCE11.90201@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, Jean Guyader <jean.guyader@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <487CCE11.90201@xxxxxxxxxxxxx> <487CCE78.9070004@xxxxxxxxxxxxx> <487CCF5D.9090200@xxxxxxxxxxxxx> <487CCE11.90201@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Hmm, I have already provided fixes for all these patches.  IanJ, it is
part of the patches I've sent you.

Jean Guyader, le Tue 15 Jul 2008 17:19:29 +0100, a écrit :
> diff --git a/xen-hooks.mak b/xen-hooks.mak
> index 4e8b1fa..af977ef 100644
> --- a/xen-hooks.mak
> +++ b/xen-hooks.mak
> @@ -39,11 +39,20 @@ OBJS += tpm_tis.o
>  
>  ifdef CONFIG_STUBDOM
>  CONFIG_PASSTHROUGH=1
> -OBJS += xenfbfront.o
> +else
> +  ifeq (,$(wildcard /usr/include/pci))
> +$(warning *** pciutils-devl package not found - missing /usr/include/pci)
> +$(warning *** PCI passthrough capability has been disabled)
> +  else
> +CONFIG_PASSTHROUGH=1
> +  endif
>  endif
>  
>  ifdef CONFIG_PASSTHROUGH
> -OBJS+= pass-through.o
> +OBJS+= pass-through.o pt-msi.o
> +LIBS += -lpci
> +CFLAGS += -DCONFIG_PASSTHROUGH 
> +$(info *** PCI passthrough capability has been enabled ***)
>  endif
>  
>  BAD_OBJS += gdbstub.o acpi.o apic.o

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


Jean Guyader, le Tue 15 Jul 2008 17:25:01 +0100, a écrit :
> ioemu-remote: Fix the pass-through compilation.
> 
> Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxxxxx>
> 
> -- 
> Jean Guyader

> diff --git a/hw/pass-through.c b/hw/pass-through.c
> index bddc203..f29f07d 100644
> --- a/hw/pass-through.c
> +++ b/hw/pass-through.c
> @@ -713,7 +713,7 @@ int pt_init(PCIBus *e_bus, char *direct_pci)
>      dpci_infos.pci_access = pci_access;
>      dpci_infos.e_bus      = e_bus;
>  
> -    if ( strlen(direct_pci) == 0 ) {
> +    if ( !direct_pci || strlen(direct_pci) == 0 ) {
>          return 0;
>      }
>  
> diff --git a/hw/pass-through.h b/hw/pass-through.h
> index ffd87ef..d642be3 100644
> --- a/hw/pass-through.h
> +++ b/hw/pass-through.h
> @@ -27,7 +27,7 @@
>  #define PT_LOGGING_ENABLED
>  
>  #ifdef PT_LOGGING_ENABLED
> -#define PT_LOG(_f, _a...)   fprintf(logfile, "%s: " _f, __func__, ##_a)
> +#define PT_LOG(_f, _a...)   fprintf(stdout, "%s: " _f, __func__, ##_a)
>  #else
>  #define PT_LOG(_f, _a...)
>  #endif

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel