WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] ioemu build failure with GCC > 4.3

To: "He, Qing" <qing.he@xxxxxxxxx>, <ian.jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] ioemu build failure with GCC > 4.3
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 10 Jul 2008 10:39:31 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 10 Jul 2008 02:39:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <37E52D09333DE2469A03574C88DBF40F021BEF97@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acjib877wCCzAHkJTmuRxJZVeQzpggAAQuDl
Thread-topic: [Xen-devel] ioemu build failure with GCC > 4.3
User-agent: Microsoft-Entourage/11.4.0.080122
On 10/7/08 10:32, "He, Qing" <qing.he@xxxxxxxxx> wrote:

> It's most straightforward to remove `inline' in slirp/misc.c, the code
> doesn't really seem to benefit from it. But it looks pretty old and not
> maintained for sometime. What about patch it locally?
> 
> Other options include specify `-fgnu89-inline' (n/a prior to GCC 4.1.3)
> and overrides slirp compile line with `-std=gnu89', but may not be
> preferred.

Could we change the '#define inline' in slirp_config.h to define it to
nothing? None of the usages of 'inline' in the slirp directory look like a
particularly good idea.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel