xen-devel
[Xen-devel] Re: [patch] x86, paravirt-spinlocks: fix boot hang
To: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
Subject: |
[Xen-devel] Re: [patch] x86, paravirt-spinlocks: fix boot hang |
From: |
Ingo Molnar <mingo@xxxxxxx> |
Date: |
Wed, 9 Jul 2008 21:26:30 +0200 |
Cc: |
Jens Axboe <axboe@xxxxxxxxx>, Nick Piggin <nickpiggin@xxxxxxxxxxxx>, Xen devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>, Christoph Lameter <clameter@xxxxxxxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Petr Tesarik <ptesarik@xxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxxxx>, Virtualization <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Thomas Friebel <thomas.friebel@xxxxxxx> |
Delivery-date: |
Wed, 09 Jul 2008 12:27:17 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<4874DF7F.4080204@xxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<20080707190749.299430659@xxxxxxxx> <20080709122852.GA30579@xxxxxxx> <20080709133358.GA7005@xxxxxxx> <20080709134944.GA15190@xxxxxxx> <4874DF7F.4080204@xxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
>> should never
>> be built with -pg (which ftrace does). Marking paravirt.o as
>> non-pg and marking all spinlock ops as always-inline solve the
>> hang.
>>
>
> Thanks Ingo, that would have taken me a while to work out.
yeah, i figured i'd be the better candidate to debug ftrace related
problems ;-)
> Presumably that means that xen/smp.o should also be built without -pg.
> In fact, should I move the spinlock code into its own file, so that
> ftrace can cover as much as it can?
hm, yeah. Anything that can be called via the lowest level spinlock
functions should be either notrace, or, better, in a -pg-excluded .o
file. Putting it all into a separate file would cover it nicely i think.
Ingo
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|