xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] minios: fix gnttab allocation boundary

from [Samuel Thibault]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] minios: fix gnttab allocation boundary
From:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date:	Tue, 17 Jun 2008 17:54:51 +0100
Delivery-date:	Tue, 17 Jun 2008 09:55:10 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.12-2006-07-14

minios: fix gnttab allocation boundary

The gnttab_sem is already fed during initialization's put_free_entry
loop.

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

diff -r 78f90b0f707f extras/mini-os/gnttab.c
--- a/extras/mini-os/gnttab.c   Tue Jun 17 14:45:18 2008 +0100
+++ b/extras/mini-os/gnttab.c   Tue Jun 17 17:53:51 2008 +0100
@@ -35,7 +35,7 @@
 #ifdef GNT_DEBUG
 static char inuse[NR_GRANT_ENTRIES];
 #endif
-static __DECLARE_SEMAPHORE_GENERIC(gnttab_sem, NR_GRANT_ENTRIES);
+static __DECLARE_SEMAPHORE_GENERIC(gnttab_sem, 0);
 
 static void
 put_free_entry(grant_ref_t ref)
@@ -60,6 +60,7 @@
     down(&gnttab_sem);
     local_irq_save(flags);
     ref = gnttab_list[0];
+    BUG_ON(ref < NR_RESERVED_ENTRIES || ref >= NR_GRANT_ENTRIES);
     gnttab_list[0] = gnttab_list[ref];
 #ifdef GNT_DEBUG
     BUG_ON(inuse[ref]);

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] minios: fix gnttab allocation boundary, Samuel Thibault <=

Previous by Date:	Re: [Xen-devel] VCPU cores & sockets, Ben Guthro
Next by Date:	Re: [Xen-devel] [PATCH] QEMU "drive_init()" Disk Format Security Bypass, Markus Armbruster
Previous by Thread:	[Xen-devel] [PATCH] doc: cpuid example for 686, Jean Guyader
Next by Thread:	[Xen-devel] How to disable PAE support in Xen in xen-unstable.hg build, Abhinav Srivastava
Indexes:	[Date] [Thread] [Top] [All Lists]