WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] reduce useless output from 'd' consolecommand

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] reduce useless output from 'd' consolecommand
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 12 Jun 2008 16:54:15 +0100
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 12 Jun 2008 08:55:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <485161F0.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjMpJBvzvX7AziXEd2vlgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] reduce useless output from 'd' consolecommand
User-agent: Microsoft-Entourage/11.4.0.080122
On 12/6/08 16:50, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 12.06.08 17:31 >>>
>> I quite like it as it is. The output for a CPU in guest mode is quite short,
>> and outputting printk("CPU%d blah") before doing the IPI also lets us see
>> very clearly if a CPU is probably not responding to IPI. I think changing
>> console_start_log_everything() to console_start_sync() would be a good idea,
>> at least for key 'd'.
> 
> The part about placement of the printk() is certainly reasonable, but
> the guest mode output being short I have to question - its stack trace
> can be as long as the hypervisor's. And clearly printing hypervisor
> context when guest execution was interrupted is pointless.

I added console_start/end_sync() to the key handler, so that at least
reduces this from an issue resulting in annoying loss of critical debug data
down to a minor quibble. And now you're *guaranteed* not to lose any debug
data (so long as all CPUs are alive) which is even better than thinning down
the output and hoping for the best.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>