WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] x86: minor adjustment to asm constraint in get_page(

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] x86: minor adjustment to asm constraint in get_page()
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 12 Jun 2008 15:38:10 +0100
Delivery-date: Thu, 12 Jun 2008 07:38:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
While not wrong, avoiding the unnecessary output allows the compiler a
little more freedom.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: 2008-06-12/xen/arch/x86/mm.c
===================================================================
--- 2008-06-12.orig/xen/arch/x86/mm.c   2008-06-12 09:08:36.000000000 +0200
+++ 2008-06-12/xen/arch/x86/mm.c        2008-06-12 09:08:42.000000000 +0200
@@ -1706,8 +1706,8 @@ int get_page(struct page_info *page, str
             return 0;
         }
         asm volatile (
-            LOCK_PREFIX "cmpxchg8b %3"
-            : "=d" (nd), "=a" (y), "=c" (d),
+            LOCK_PREFIX "cmpxchg8b %2"
+            : "=d" (nd), "=a" (y),
             "=m" (*(volatile u64 *)(&page->count_info))
             : "0" (d), "1" (x), "c" (d), "b" (nx) );
     }




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] x86: minor adjustment to asm constraint in get_page(), Jan Beulich <=