WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]Fix memory leak for copy-receiver of netfront

To: Kasai Takanori <kasai.takanori@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]Fix memory leak for copy-receiver of netfront
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Wed, 11 Jun 2008 22:33:02 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 11 Jun 2008 14:34:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <37C8CB88D5C4E2kasai.takanori@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <37C8CB88D5C4E2kasai.takanori@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080501)
Kasai Takanori wrote:
Hi all,

We found the problem of the memory leak when working with copy-
receiver of netfront.

The source of a problem is that the fragment page is not released with dev_kfree_skb() because the nr_frags variable of skb is set to 0.
This is the patch to fix memory leak in netfront.

This code doesn't apply to the current 2.6.25 version of netfront. The only similar code I could see is:

               skb = np->rx_skbs[id];
               mfn = gnttab_end_foreign_transfer_ref(ref);
               gnttab_release_grant_reference(&np->gref_rx_head, ref);
               np->grant_rx_ref[id] = GRANT_INVALID_REF;

               if (0 == mfn) {
                       skb_shinfo(skb)->nr_frags = 0;
                       dev_kfree_skb(skb);
                       noxfer++;
                       continue;
               }


Would you mind reviewing the 2.6.25 version of netfront to see if it needs a patch?

Thanks,
   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>