WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][TOOLS] libfsimage: make pygrub work on ufs

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH][TOOLS] libfsimage: make pygrub work on ufs
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Tue, 10 Jun 2008 12:40:57 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 10 Jun 2008 04:42:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200806101024.57045.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200806091559.45511.Christoph.Egger@xxxxxxx> <20080609155033.GA28374@xxxxxxxxxxxxxxxxxxxxxxx> <200806101024.57045.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Tue, Jun 10, 2008 at 10:24:56AM +0200, Christoph Egger wrote:

> > > @@ -32,8 +32,9 @@
> > >  #define SUPERBLOCK ((struct fs *)(FSYS_BUF + 0x2000))
> > >  #define  INODE ((struct icommon *)(FSYS_BUF + 0x1000))
> > >  #define DIRENT (FSYS_BUF + 0x4000)
> > > +#define MAXBSIZE ((FSYS_BUFLEN - 0x4000) / 2)
> > >  #define INDIRBLK1 ((grub_daddr32_t *)(FSYS_BUF + 0x4000)) /* 2+ indirblk 
> */ 
> > >  -#define INDIRBLK0 ((grub_daddr32_t *)(FSYS_BUF+ 0x6000))  /* 1st 
> indirect blk */
> > > +#define  INDIRBLK0 ((grub_daddr32_t *)(FSYS_BUF+ 0x4000 + MAXBSIZE))  /* 
> 1st indirect blk */
> >
> > This is a no-op, right?
> 
> No, FSYS_BUFLEN is used now which wasn't before.

Ooops, I mis-read the value of FSYS_BUFLEN. So you need this because
indirect blocks don't fit in the original space available?

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel