WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [HVM] fix tracing for 64bit guests

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [HVM] fix tracing for 64bit guests
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 10 Jun 2008 10:27:09 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 10 Jun 2008 02:28:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <484E4125.7040502@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjK3CfVZlrifTbPEd2k+wAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] [HVM] fix tracing for 64bit guests
User-agent: Microsoft-Entourage/11.4.0.080122
On 10/6/08 09:53, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> This basically will always log 64bit values for the instruction pointer.
> I thought about this approach, too, but didn't do it because I got the
> impression that trace files are large enough and with the recently
> introduced 'variable number of parameters' saving disk space is a concern.
> Do you want to promote other pointers to always 64bit, too? Shall I
> prepare a patch for this?

My opinion is if it's efficient enough for 64-bit guests then it must be
good enough for 32-bit guests too. Further, I don't want extra usually
unnecessary checks on the common vmentry/vmexit paths, and always using the
64-bit version reduces code clutter.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>