WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/2] Improve hpet accuracy

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/2] Improve hpet accuracy
From: Dave Winchell <dwinchell@xxxxxxxxxxxxxxx>
Date: Mon, 09 Jun 2008 09:08:53 -0400
Cc: dan.magenheimer@xxxxxxxxxx, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Dave Winchell <dwinchell@xxxxxxxxxxxxxxx>, Ben Guthro <bguthro@xxxxxxxxxxxxxxx>
Delivery-date: Mon, 09 Jun 2008 06:07:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C472DC3A.21C60%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C472DC3A.21C60%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
Keir Fraser wrote:

On 9/6/08 13:03, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

        ok, I'll work on this. How much time do I have to make the
        release you are
        working on?


    I’m thinking feature freeze at the end of the month.


Oh, while I’m commenting on the current version of the patch, I will point out that changes to the save/restore format need careful thought. At the very least we’d like to be backward compatible (old images restore on new Xen) even if we don’t achieve compatibility the other way round. I didn’t really look too closely at this aspect of the patches so perhaps these patches are fine in this regard.

I'll look into the live migrate from old to new.

Either way I think the core re-architecting of the hpet device model to handle missed ticks and so on is independent of interface changes anyway (apart from reasonable extensions to the timer_mode option). Changes to save/restore format, addition of extra debugging code, and peripheral things like that it’d be nice to have in separate patches. It makes the core stuff easier to review and more likely to get accepted without quibble (because there’s less of it, and it is all dedicated to a single purpose which I think we all agree is where we want to be).

This is fine. I'll break up the patch along the lines you suggest.


Thanks,
Keir

Thanks,
Dave

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel