WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [patch]Fix a bug that can't resume from S3 after createa

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [patch]Fix a bug that can't resume from S3 after createan HVM guest
From: "Chen, Huacai" <huacai.chen@xxxxxxxxx>
Date: Fri, 6 Jun 2008 10:18:48 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 05 Jun 2008 19:19:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <42DFA526FC41B1429CE7279EF83C6BDC013C5C1B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <42DFA526FC41B1429CE7279EF83C6BDC013C5C1B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcjHb+356bLVKox0Tdy2FrLQd90X8AACvq7Q
Thread-topic: [Xen-devel] [patch]Fix a bug that can't resume from S3 after createan HVM guest
This new patch may be better, just remove "__init" modifier of 
disable_pit_irq().

Signed-off-by: Huacai Chen <huacai.chen@xxxxxxxxx>
Signed-off-by: Li Zhang <li.zhang@xxxxxxxxx>

-----Original Message-----
From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Chen, Huacai
Sent: 2008年6月6日 8:55
To: Keir Fraser
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [patch]Fix a bug that can't resume from S3 after createan 
HVM guest

Hi, Keir,

If we don't use PIT, we should disable it at boot time and at S3
resuming. In Xen this is done by disable_pit_irq(), but this function is
used by __initcall(). After bootstrap it will be discarded and may be
overwritten. This usually results in S3 resuming failure. This patch
fixed the issue.
 
Signed-off-by: Huacai Chen <huacai.chen@xxxxxxxxx>
Signed-off-by: Li Zhang <li.zhang@xxxxxxxxx>

Attachment: s3_disable_pit.patch
Description: s3_disable_pit.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>